This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Making hypercube_url overrideable. Using variable for syn token. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Jan 29, 2020
|
I'm happy to close #13 over getting this merged. Basically ran into this issue earlier this morning. |
ruebot
added a commit
to yorkulibraries/yudl-playbook
that referenced
this pull request
Nov 16, 2020
- Addresses #24 - Depends on: - islandora-deprecated/ansible-role-alpaca#13 - or - islandora-deprecated/ansible-role-alpaca#9
|
This is good to go. I took a glance at it and thought I still needed to add a default, but looks like I already did 😎 |
|
Groveling for a merge here @Islandora-Devops/committers |
|
would you like a full run build test? |
|
I'm spinning up an ubuntu right now. |
|
I'm happy to argue I've tested this a fair bit with our staging adaptation of the playbooks, and it's good to merge 😄 |
|
Granted, if my network is as bad today as yesterday, it will be more than an hour before I actually get to test it. 😅 |
|
Ubuntu checked out. Spinning up centos and then we can put this to bed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1409
What does this Pull Request do?
Makes a variable for hypercube's url and uses it. Also uses the pre-existing
islandora_syn_tokenfor configuring alpaca's http client. With this, we can eliminate having to updatekaraf.ymlin our inventory for provisioning remote servers.How should this be tested?
Pull in this PR, delete
roles/external, thenvagrant up. Everything should provision normally. Try creating an OCR derivative and see if it still works.Interested parties
@Islandora-Devops/committers